-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-120541: Improve the "less" prompt in pydoc #120543
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When help() is called with non-string argument, use __qualname__ or __name__ if available, otherwise use "{typename} object".
AlexWaygood
reviewed
Jun 15, 2024
Misc/NEWS.d/next/Library/2024-06-15-12-04-46.gh-issue-120541.d3cc5y.rst
Outdated
Show resolved
Hide resolved
AlexWaygood
reviewed
Jun 15, 2024
AlexWaygood
reviewed
Jun 15, 2024
AlexWaygood
approved these changes
Jun 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice enhancement.
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 15, 2024
When help() is called with non-string argument, use __qualname__ or __name__ if available, otherwise use "{typename} object". (cherry picked from commit 31d1d72) Co-authored-by: Serhiy Storchaka <[email protected]>
GH-120562 is a backport of this pull request to the 3.13 branch. |
Thank you for your review, @AlexWaygood. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 15, 2024
…120562) When help() is called with non-string argument, use __qualname__ or __name__ if available, otherwise use "{typename} object". (cherry picked from commit 31d1d72) Co-authored-by: Serhiy Storchaka <[email protected]>
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
When help() is called with non-string argument, use __qualname__ or __name__ if available, otherwise use "{typename} object".
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
When help() is called with non-string argument, use __qualname__ or __name__ if available, otherwise use "{typename} object".
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
When help() is called with non-string argument, use __qualname__ or __name__ if available, otherwise use "{typename} object".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When help() is called with non-string argument, use qualname or name if available, otherwise use "{typename} object".